Commits
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.45.0 to 0.52.0.
- [Commits](https://github.com/golang/crypto/compare/v0.45.0...v0.52.0)
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.52.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
previously, the request URL was cached and that sucked because like... it had wss:// (which request.to) doesn't like
that introduced a bug where we didn't change wss:// to https:// in the reconnect function, which silently failed to connect
also i left a mean comment in the past and that was kinda dumb
now i cache the request object, which means that we no longer have this issue! (hopefully, i really haven't been able to test lmao)
Bug 1 (resume, line 2840): ResetHeartbeatCount → StopHeartbeats.
The old heartbeat manager was kept alive with a reset count instead of
being terminated. It accumulated unacknowledged heartbeats and eventually
fired a HeartbeatInequalityDisconnect, tearing down the newly-resumed
connection.
Bug 2 (on_hello_event, lines 3384-3432): on_hello_event now checks
whether we are doing a fresh connection (GettingReady/Welcomed) or a
resume (Identified). During a resume the function previously:
- transitioned unconditionally to Welcomed state, losing session_id,
resume_gateway_url and sequence
- called send_identify(), sending IDENTIFY to Discord and overriding
the RESUME that was already queued
Now, when the incoming state is Identified (resume path), the function
stops the old heartbeat manager defensively, creates a new one, and
stays in Identified state — preserving all session fields. IDENTIFY is
not sent; the RESUME queued by resume() is used instead. As a result
RESUMED is handled correctly by the existing Identified on_dispatch
handler and all events flow normally after a resume.
Agent-Logs-Url: https://github.com/folospior/grom/sessions/fd438628-6f79-495c-bc1b-209a482845b4
Co-authored-by: folospior <111700958+folospior@users.noreply.github.com>
i apologize for bad error types, i promise i'll be better in the future
Signed-off-by: Filip Hoffmann <folosp@protonmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20210421170649-83a5a9bb288b to 0.45.0.
- [Commits](https://github.com/golang/crypto/commits/v0.45.0)
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.45.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.45.0 to 0.52.0.
- [Commits](https://github.com/golang/crypto/compare/v0.45.0...v0.52.0)
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.52.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
previously, the request URL was cached and that sucked because like... it had wss:// (which request.to) doesn't like
that introduced a bug where we didn't change wss:// to https:// in the reconnect function, which silently failed to connect
also i left a mean comment in the past and that was kinda dumb
now i cache the request object, which means that we no longer have this issue! (hopefully, i really haven't been able to test lmao)
Bug 1 (resume, line 2840): ResetHeartbeatCount → StopHeartbeats.
The old heartbeat manager was kept alive with a reset count instead of
being terminated. It accumulated unacknowledged heartbeats and eventually
fired a HeartbeatInequalityDisconnect, tearing down the newly-resumed
connection.
Bug 2 (on_hello_event, lines 3384-3432): on_hello_event now checks
whether we are doing a fresh connection (GettingReady/Welcomed) or a
resume (Identified). During a resume the function previously:
- transitioned unconditionally to Welcomed state, losing session_id,
resume_gateway_url and sequence
- called send_identify(), sending IDENTIFY to Discord and overriding
the RESUME that was already queued
Now, when the incoming state is Identified (resume path), the function
stops the old heartbeat manager defensively, creates a new one, and
stays in Identified state — preserving all session fields. IDENTIFY is
not sent; the RESUME queued by resume() is used instead. As a result
RESUMED is handled correctly by the existing Identified on_dispatch
handler and all events flow normally after a resume.
Agent-Logs-Url: https://github.com/folospior/grom/sessions/fd438628-6f79-495c-bc1b-209a482845b4
Co-authored-by: folospior <111700958+folospior@users.noreply.github.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20210421170649-83a5a9bb288b to 0.45.0.
- [Commits](https://github.com/golang/crypto/commits/v0.45.0)
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-version: 0.45.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>