danielroe.dev
[READ-ONLY] Mirror of https://github.com/danielroe/ripple-framework. Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.
chore: update pull request template
author
dylankelly
committer
GitHub
date
(May 16, 2022, 4:05 PM +1000)
commit
29a13691
29a136913da4fca8cec2c973291c03f344cf55b4
parent
32f6bb65
32f6bb659df71ef358a2c8238cfbecc40a37c1d0
+28
-4
+28
-4
.github/PULL_REQUEST_TEMPLATE.md
+28
-4
.github/PULL_REQUEST_TEMPLATE.md
···
1
-
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)
1
+
<!-- Add Jira ID Eg: SDPA-1234 or GitHub Issue Number eg: #123 -->
2
2
3
-
- **What is the current behavior?** (You can also link to an open issue here)
3
+
**Issue**:
4
4
5
-
- **What is the new behavior (if this is a feature change)?**
5
+
### What I did
6
+
<!-- Summary of changes made in the Pull Request -->
7
+
-
8
+
-
6
9
7
-
- **Other information**:
10
+
### How to test
11
+
<!-- Summary of how to test -->
12
+
-
13
+
-
14
+
15
+
### Checklist
16
+
17
+
<!-- Go over all the following points, and put an `x` in all the boxes that apply. -->
18
+
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
19
+
20
+
#### For all PR's
21
+
22
+
- [ ] I've added relevant changes to the project Readme if needed.
23
+
- [ ] I've updated the documentation site as needed.
24
+
- [ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)
25
+
26
+
#### For new components only
27
+
28
+
- [ ] I have added a story covering all variants
29
+
- [ ] I have checked a11y tab in storybook passes
30
+
- [ ] Any events are emitted on the event bus
31
+