gazagnaire.org
vAccel RPC protocol in pure OCaml
vaccel: name the option-returning payload projector for the lint
The file-local helper in Agent decodes a request payload and projects one field, returning None when the payload does not decode. Named get, it tripped merlint E325: an option-returning accessor must not use the get_ family. A bare descriptive name is the convention for option returns, so it is now field.
This clears the pre-existing naming issue that made the package-scoped pre-commit hook (git x commit create --hook-dir ocaml-vaccel) reject every commit in the package.
author
Thomas Gazagnaire
date
(Jul 16, 2026, 6:15 PM UTC)
commit
dcbd2560
dcbd256058954fc9d0cca0dfdeb00b7619160e88
parent
66ba1c8d
66ba1c8d17154f7b945ba2cbb6ebe5df9871adf3
+24
-21
+24
-21
lib/agent.ml
+24
-21
lib/agent.ml
···
51
51
52
52
(* Decode [payload] with [codec] and project one field, or [None] when the
53
53
payload does not decode. *)
54
-
let get codec payload f =
54
+
let field codec payload f =
55
55
match Protobuf.of_string codec payload with
56
56
| Ok r -> Some (f r)
57
57
| Error _ -> None
···
67
67
| "UpdateSession" ->
68
68
Some
69
69
(fun p ->
70
-
get Session.Update.request p (fun (r : Session.Update.request) ->
70
+
field Session.Update.request p (fun (r : Session.Update.request) ->
71
71
r.session_id))
72
72
| "DestroySession" ->
73
73
Some
74
74
(fun p ->
75
-
get Session.Destroy.request p (fun (r : Session.Destroy.request) ->
75
+
field Session.Destroy.request p (fun (r : Session.Destroy.request) ->
76
76
r.session_id))
77
77
| "RegisterResource" ->
78
78
Some
79
79
(fun p ->
80
-
get Resource.register_request p
80
+
field Resource.register_request p
81
81
(fun (r : Resource.register_request) -> r.session_id))
82
82
| "UnregisterResource" ->
83
83
Some
84
84
(fun p ->
85
-
get Resource.unregister_request p
85
+
field Resource.unregister_request p
86
86
(fun (r : Resource.unregister_request) -> r.session_id))
87
87
| "ImageClassification" ->
88
88
Some
89
-
(fun p -> get Image.request p (fun (r : Image.request) -> r.session_id))
89
+
(fun p ->
90
+
field Image.request p (fun (r : Image.request) -> r.session_id))
90
91
| "TensorflowModelLoad" ->
91
92
Some
92
93
(fun p ->
93
-
get Tf.model_load_request p (fun (r : Tf.model_load_request) ->
94
+
field Tf.model_load_request p (fun (r : Tf.model_load_request) ->
94
95
r.session_id))
95
96
| "TensorflowModelUnload" ->
96
97
Some
97
98
(fun p ->
98
-
get Tf.model_unload_request p (fun (r : Tf.model_unload_request) ->
99
+
field Tf.model_unload_request p (fun (r : Tf.model_unload_request) ->
99
100
r.session_id))
100
101
| "TensorflowModelRun" ->
101
102
Some
102
103
(fun p ->
103
-
get Tf.model_run_request p (fun (r : Tf.model_run_request) ->
104
+
field Tf.model_run_request p (fun (r : Tf.model_run_request) ->
104
105
r.session_id))
105
106
| "TensorflowLiteModelLoad" ->
106
107
Some
107
108
(fun p ->
108
-
get Tflite.model_load_request p
109
+
field Tflite.model_load_request p
109
110
(fun (r : Tflite.model_load_request) -> r.session_id))
110
111
| "TensorflowLiteModelUnload" ->
111
112
Some
112
113
(fun p ->
113
-
get Tflite.model_unload_request p
114
+
field Tflite.model_unload_request p
114
115
(fun (r : Tflite.model_unload_request) -> r.session_id))
115
116
| "TensorflowLiteModelRun" ->
116
117
Some
117
118
(fun p ->
118
-
get Tflite.model_run_request p (fun (r : Tflite.model_run_request) ->
119
-
r.session_id))
119
+
field Tflite.model_run_request p
120
+
(fun (r : Tflite.model_run_request) -> r.session_id))
120
121
| "TorchModelLoad" ->
121
122
Some
122
123
(fun p ->
123
-
get Torch.model_load_request p (fun (r : Torch.model_load_request) ->
124
-
r.session_id))
124
+
field Torch.model_load_request p
125
+
(fun (r : Torch.model_load_request) -> r.session_id))
125
126
| "TorchModelRun" ->
126
127
Some
127
128
(fun p ->
128
-
get Torch.model_run_request p (fun (r : Torch.model_run_request) ->
129
+
field Torch.model_run_request p (fun (r : Torch.model_run_request) ->
129
130
r.session_id))
130
131
| "Genop" ->
131
132
Some
132
-
(fun p -> get Genop.request p (fun (r : Genop.request) -> r.session_id))
133
+
(fun p ->
134
+
field Genop.request p (fun (r : Genop.request) -> r.session_id))
133
135
| "GetProfiler" ->
134
136
Some
135
137
(fun p ->
136
-
get Profiling.request p (fun (r : Profiling.request) -> r.session_id))
138
+
field Profiling.request p (fun (r : Profiling.request) ->
139
+
r.session_id))
137
140
| _ -> None
138
141
139
142
let request_session_id ~meth payload =
···
144
147
let request_resource_id ~meth payload =
145
148
match meth with
146
149
| "RegisterResource" ->
147
-
get Resource.register_request payload
150
+
field Resource.register_request payload
148
151
(fun (r : Resource.register_request) -> r.resource_id)
149
152
| "UnregisterResource" ->
150
-
get Resource.unregister_request payload
153
+
field Resource.unregister_request payload
151
154
(fun (r : Resource.unregister_request) -> r.resource_id)
152
155
| "SyncResource" ->
153
-
get Resource.sync_request payload (fun (r : Resource.sync_request) ->
156
+
field Resource.sync_request payload (fun (r : Resource.sync_request) ->
154
157
r.resource_id)
155
158
| _ -> None