isaaccorbrey.com / burin
A post-modern development environment.
0
Fork 0

Configure Feed

Select the types of activity you want to include in your feed.

minor: Tweak some verbose LSP logs

The info log within `process_request_response` duplicated the body of
the JSON message printed earlier by the transport which was confusing.

The error log in the completion handler was easy to hit during normal
use and is not actually an error - dropping is the graceful way to
handle changes occurring while completion requests are in flight.

author
Michael Davis date (Mar 4, 2025, 11:25 AM -0500) commit ab56f9e2 parent 1d453785
+2 -5
+1 -4
helix-lsp/src/transport.rs
··· 223 223 language_server_name: &str, 224 224 ) -> Result<()> { 225 225 let (id, result) = match output { 226 - jsonrpc::Output::Success(jsonrpc::Success { id, result, .. }) => { 227 - info!("{language_server_name} <- {}", result); 228 - (id, Ok(result)) 229 - } 226 + jsonrpc::Output::Success(jsonrpc::Success { id, result, .. }) => (id, Ok(result)), 230 227 jsonrpc::Output::Failure(jsonrpc::Failure { id, error, .. }) => { 231 228 error!("{language_server_name} <- {error}"); 232 229 (id, Err(error.into()))
+1 -1
helix-term/src/handlers/completion.rs
··· 57 57 return; 58 58 }; 59 59 if handle.is_canceled() { 60 - log::error!("dropping outdated completion response"); 60 + log::info!("dropping outdated completion response"); 61 61 return; 62 62 } 63 63