mary.my.id
personal fork of bluesky app
bsky.kelinci.net
refactor: drop redundant account key from app tree
the key={currentAccount?.did} fragment only wrapped QueryProvider, whose
own key={currentDid} already remounts the whole subtree on account change
and owns query-cache isolation, so the outer key was a no-op.
author
Mary
date
(Jul 23, 2026, 2:21 PM +0700)
commit
ae2a2dfb
ae2a2dfb048a04f32d87f4eb0b4ae20ff3409ddf
parent
1c6719d2
1c6719d27bec4dd2a4a0f3b7aa89ab93aee3f101
+27
-31
+27
-31
src/App.tsx
+27
-31
src/App.tsx
···
2
2
import '#/styles/reset.css';
3
3
import '#/styles/theme.css';
4
4
5
-
import { Fragment, useEffect } from 'react';
5
+
import { useEffect } from 'react';
6
6
7
7
import { Provider as HotkeysProvider } from '#/lib/hotkeys';
8
8
import { initializeLanguageDetection } from '#/lib/language-detection';
···
46
46
<Splash isReady={!isSessionResuming}>
47
47
<VideoVolumeProvider>
48
48
<ActiveVideoProvider>
49
-
<Fragment
50
-
// Resets the entire tree below when it changes:
51
-
key={currentAccount?.did}
52
-
>
53
-
<QueryProvider currentDid={currentAccount?.did}>
54
-
<MessagesProvider>
55
-
{/* LabelDefsProvider MUST come before ModerationOptsProvider */}
56
-
<LabelDefsProvider>
57
-
<ModerationOptsProvider>
58
-
<SelectedFeedProvider>
59
-
<HiddenRepliesProvider>
60
-
<UnreadNotifsProvider>
61
-
<MutedThreadsProvider>
62
-
<ServiceConfigProvider>
63
-
<HideBottomBarBorderProvider>
64
-
<HotkeysProvider>
65
-
<Shell />
66
-
<ToastOutlet />
67
-
</HotkeysProvider>
68
-
</HideBottomBarBorderProvider>
69
-
</ServiceConfigProvider>
70
-
</MutedThreadsProvider>
71
-
</UnreadNotifsProvider>
72
-
</HiddenRepliesProvider>
73
-
</SelectedFeedProvider>
74
-
</ModerationOptsProvider>
75
-
</LabelDefsProvider>
76
-
</MessagesProvider>
77
-
</QueryProvider>
78
-
</Fragment>
49
+
{/* QueryProvider resets children on currentDid changes */}
50
+
<QueryProvider currentDid={currentAccount?.did}>
51
+
<MessagesProvider>
52
+
{/* LabelDefsProvider MUST come before ModerationOptsProvider */}
53
+
<LabelDefsProvider>
54
+
<ModerationOptsProvider>
55
+
<SelectedFeedProvider>
56
+
<HiddenRepliesProvider>
57
+
<UnreadNotifsProvider>
58
+
<MutedThreadsProvider>
59
+
<ServiceConfigProvider>
60
+
<HideBottomBarBorderProvider>
61
+
<HotkeysProvider>
62
+
<Shell />
63
+
<ToastOutlet />
64
+
</HotkeysProvider>
65
+
</HideBottomBarBorderProvider>
66
+
</ServiceConfigProvider>
67
+
</MutedThreadsProvider>
68
+
</UnreadNotifsProvider>
69
+
</HiddenRepliesProvider>
70
+
</SelectedFeedProvider>
71
+
</ModerationOptsProvider>
72
+
</LabelDefsProvider>
73
+
</MessagesProvider>
74
+
</QueryProvider>
79
75
</ActiveVideoProvider>
80
76
</VideoVolumeProvider>
81
77
</Splash>